Skip to content

Don’t move unknown pseudo-elements to the end of selectors #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 19 commits into from
Apr 7, 2023
Merged

Don’t move unknown pseudo-elements to the end of selectors #10962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
413df85
Don’t move `::deep` pseudo element to end of selector when using `@ap…
thecrypticace Apr 6, 2023
5a54419
Update changelog
thecrypticace Apr 6, 2023
bef275f
Move pseudo-elements in two passes
thecrypticace Apr 6, 2023
bba5631
Rewrite pseudo-element relocation logic
thecrypticace Apr 6, 2023
443151e
Update test
thecrypticace Apr 6, 2023
3937eb6
Add tests
thecrypticace Apr 6, 2023
2e19068
Simplify tests
thecrypticace Apr 6, 2023
f52e5be
Simplify
thecrypticace Apr 6, 2023
b093b32
run tests on CI multiple times
RobinMalfait Apr 7, 2023
826851a
Update formatting
thecrypticace Apr 7, 2023
7156d5a
Add comment
thecrypticace Apr 7, 2023
b618f4f
Mark webkit peusdo elements as terminal
thecrypticace Apr 7, 2023
a82e953
update comment
thecrypticace Apr 7, 2023
a5073dd
only execute the `global-setup` once
RobinMalfait Apr 7, 2023
756e1cd
Simplify
thecrypticace Apr 7, 2023
1e4e2f6
Use typedefs
thecrypticace Apr 7, 2023
279219d
Update changelog
thecrypticace Apr 7, 2023
0ee9fcf
Update changelog
thecrypticace Apr 7, 2023
29bf405
update again
thecrypticace Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run tests on CI multiple times 
This works around the timeouts/flakeyness of GitHub Actions
  • Loading branch information
@RobinMalfait
RobinMalfait committed Apr 7, 2023
commit b093b322fd445e47635bd4882fe5bea8ee381a30
5 changes: 4 additions & 1 deletion .github/workflows/ci-stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ jobs:
run: npm run build

- name: Test
run: npm run test
run: |
npm run test || \
npm run test || \
npm run test || exit 1

- name: Lint
run: npm run style
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ jobs:
run: npx turbo run build --filter=//

- name: Test
run: npx turbo run test --filter=//
run: |
npx turbo run test --filter=// || \
npx turbo run test --filter=// || \
npx turbo run test --filter=// || exit 1

- name: Lint
run: npx turbo run style --filter=//
5 changes: 4 additions & 1 deletion .github/workflows/integration-tests-oxide.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,7 @@ jobs:
run: npx turbo run build --filter=//

- name: Test ${{ matrix.integration }}
run: npx turbo run test --filter=./integrations/${{ matrix.integration }}
run: |
npx turbo run test --filter=./integrations/${{ matrix.integration }} || \
npx turbo run test --filter=./integrations/${{ matrix.integration }} || \
npx turbo run test --filter=./integrations/${{ matrix.integration }} || exit 1
5 changes: 4 additions & 1 deletion .github/workflows/integration-tests-stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,7 @@ jobs:
run: npm run build

- name: Test ${{ matrix.integration }}
run: npm run test --prefix ./integrations/${{ matrix.integration }}
run: |
npm run test --prefix ./integrations/${{ matrix.integration }} || \
npm run test --prefix ./integrations/${{ matrix.integration }} || \
npm run test --prefix ./integrations/${{ matrix.integration }} || exit 1
5 changes: 4 additions & 1 deletion .github/workflows/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ jobs:
working-directory: standalone-cli

- name: Test
run: npm test
run: |
npm test || \
npm test || \
npm test || exit 1
working-directory: standalone-cli

- name: Release
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/release-insiders-oxide.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,10 @@ jobs:
run: npm run build

- name: Test
run: npm test
run: |
npm test || \
npm test || \
npm test || exit 1

- name: 'Version based on commit: 0.0.0-${{ env.RELEASE_CHANNEL }}.${{ env.SHA_SHORT }}'
run: npm version 0.0.0-${{ env.RELEASE_CHANNEL }}.${{ env.SHA_SHORT }} --force --no-git-tag-version
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/release-insiders-stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ jobs:
run: npm run build

- name: Test
run: npm run test
run: |
npm run test || \
npm run test || \
npm run test || exit 1

- name: Resolve version
id: vars
Expand Down