Skip to content

Reset dialog element styles #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 5 commits into from
Apr 28, 2023
Merged

Reset dialog element styles #11069

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e77ba4
disable useragent styling for dialog
eranhirsch Apr 23, 2023
69d78ff
nits
eranhirsch Apr 23, 2023
f7ef314
Update src/css/preflight.css
eranhirsch Apr 24, 2023
8dd4b81
Simplify dialog reset
thecrypticace Apr 28, 2023
6924e8c
Update test
thecrypticace Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
disable useragent styling for dialog
  • Loading branch information
@eranhirsch @thecrypticace
eranhirsch authored and thecrypticace committed Apr 28, 2023
commit 2e77ba4e112fcfa594d579a26d5f99bcf5a5efbb
13 changes: 13 additions & 0 deletions src/css/preflight.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,18 @@ menu {
padding: 0;
}

/*
Reset default styling for dialogs.
*/
dialog {
margin: 0;
border: none;
padding: 0;
background: transparent;
Copy link

@ben-rogerson ben-rogerson Apr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit here - with a double space before transparent

color: inherit;
}


/*
Prevent resizing textareas horizontally by default.
*/
Expand Down Expand Up @@ -369,3 +381,4 @@ video {
[hidden] {
display: none;
}