Add size-text shorthand #12292
Closed
Add size-text shorthand #12292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey thanks for the PR! For now going to say no to this because we don’t include this size anywhere else in the framework, so it’s a bit of a bigger decision and can’t prioritize thinking it through right now. Maybe in the future though 👍🏻 |
Author
|
No worries Adam! I submitted this because I use it on every project and have seen others doing the same too but I am sure you have a better overview of what is widely needed and what is not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
size-textutility that setswidthandheightto1em.This is super useful when making icons and other elements that can then be controlled by setting a font-size on the parent or the element itself.
Relates to #12287