Skip to content

Add * variant for targeting direct children #12551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 5 commits into from
Dec 9, 2023
Merged

Add * variant for targeting direct children #12551

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a89a9d8
WIP
adamwathan Dec 8, 2023
5de784e
add `*` as allowed variant characters
RobinMalfait Dec 8, 2023
050c927
update test to reflect Lightning CSS output
RobinMalfait Dec 8, 2023
2eab78f
add `childVariant` test
RobinMalfait Dec 8, 2023
c35e673
Update changelog
adamwathan Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test to reflect Lightning CSS output
  • Loading branch information
@RobinMalfait
RobinMalfait committed Dec 8, 2023
commit 050c927d9725856bb129fb291fd0204048b4eee1
18 changes: 5 additions & 13 deletions tests/variants.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,19 +1191,11 @@ test('* is matched by the parser as the children variant', async () => {
let result = await run(input, config)

expect(result.css).toMatchFormattedCss(css`
.\*\:italic > * {
font-style: italic;
}
.\*\:hover\:italic:hover > * {
font-style: italic;
}
.hover\:\*\:italic > *:hover {
font-style: italic;
}
.data-\[slot\=label\]\:\*\:hover\:italic:hover > *[data-slot='label'] {
font-style: italic;
}
.\[\&\_p\]\:\*\:hover\:italic:hover > * p {
.\*\:italic > *,
.\*\:hover\:italic:hover > *,
.hover\:\*\:italic > :hover,
.data-\[slot\=label\]\:\*\:hover\:italic:hover > [data-slot='label'],
.\[\&_p\]\:\*\:hover\:italic:hover > * p {
font-style: italic;
}
`)
Expand Down