Skip to content

Restore old behavior for class dark mode, add new selector and variant options for dark mode #12717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 24 commits into from
Jan 5, 2024
Merged

Restore old behavior for class dark mode, add new selector and variant options for dark mode #12717

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1544ef5
Add dark mode variant option
thecrypticace Dec 21, 2023
a94a212
Tweak warning messages
thecrypticace Dec 21, 2023
543dacf
Add legacy dark mode option
thecrypticace Dec 21, 2023
c055aa4
wip
thecrypticace Dec 21, 2023
13ad6cc
Use `class` for legacy behavior, `selector` for new behavior
adamwathan Dec 22, 2023
c221bbc
Add simplified failing apply/where test case
adamwathan Dec 22, 2023
24d1923
Switch to `where` list, apply changes to `dir` variants
adamwathan Dec 22, 2023
14b8e0e
Don’t let `:where`, `:is:`, or `:has` be attached to pseudo elements
thecrypticace Dec 22, 2023
aed8a36
Updating tests...
adamwathan Dec 22, 2023
2433d99
Finish updating tests
adamwathan Dec 22, 2023
1852504
Remove `variant` dark mode strategy
thecrypticace Jan 5, 2024
d3fd11a
Update types
thecrypticace Jan 5, 2024
3a2f2a2
Update comments
thecrypticace Jan 5, 2024
a18f96b
Update changelog
thecrypticace Jan 5, 2024
6498502
Revert "Remove `variant` dark mode strategy"
thecrypticace Jan 5, 2024
25728c0
Add variant back to types
thecrypticace Jan 5, 2024
10e690c
wip
thecrypticace Jan 5, 2024
44fc78a
Update comments
thecrypticace Jan 5, 2024
4921319
Update tests
thecrypticace Jan 5, 2024
0e02e86
Rename variable
thecrypticace Jan 5, 2024
9c889fe
Update changelog
thecrypticace Jan 5, 2024
c16b1d6
Update changelog
thecrypticace Jan 5, 2024
fe0488c
Update changelog
thecrypticace Jan 5, 2024
eca8fff
Fix CS
thecrypticace Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix CS
  • Loading branch information
@thecrypticace
thecrypticace committed Jan 5, 2024
commit eca8fff928a73bcf476ca9fc7386ae82fc4aaea8
1 change: 0 additions & 1 deletion tests/plugins/variants/darkVariants.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,3 @@ quickVariantPluginTest('darkVariants', {
quickVariantPluginTest('darkVariants', {
darkMode: ['selector', '.my-dark-mode'],
}).toMatchSnapshot()