Skip to content

Change dark selector so @apply works correctly with pseudo elements #13379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 3 commits into from
Mar 27, 2024
Merged

Change dark selector so @apply works correctly with pseudo elements #13379

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b04d9b3
Change dark selector so `@apply` hoists pseudo elements properly
thecrypticace Mar 27, 2024
fe5a3c1
Update tests
thecrypticace Mar 27, 2024
5711371
Update changelog
thecrypticace Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change dark selector so @apply hoists pseudo elements properly
  • Loading branch information
@thecrypticace
thecrypticace committed Mar 27, 2024
commit b04d9b33558e5c412a5678e0f922add45d673956
2 changes: 1 addition & 1 deletion src/corePlugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export let variantPlugins = {
addVariant('dark', selector)
} else if (mode === 'class') {
// Old behavior
addVariant('dark', `:is(${selector} &)`)
addVariant('dark', `&:is(${selector} *)`)
}
},

Expand Down