Skip to content

Discard invalid classes such as bg-red-[#000] #13970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 8 commits into from
Jul 10, 2024
Merged

Discard invalid classes such as bg-red-[#000] #13970

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
29cb8a6
add test that verifies that parsing `bg-red-[#0088cc]` should not work
RobinMalfait Jul 8, 2024
ecca157
improve parsing of arbitrary values, root is known
RobinMalfait Jul 8, 2024
d400c4f
small refactor: define `important` and `negative` directly
RobinMalfait Jul 8, 2024
6caf3dd
small refactor: use return on same line for consistency
RobinMalfait Jul 8, 2024
595da63
add test that verifies that parsing `bg-` should not work
RobinMalfait Jul 8, 2024
e98edfd
move `value === ''` check up
RobinMalfait Jul 8, 2024
52e6409
adjust comment with example
RobinMalfait Jul 8, 2024
65929bd
update changelog
RobinMalfait Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
small refactor: use return on same line for consistency
  • Loading branch information
@RobinMalfait
RobinMalfait committed Jul 8, 2024
commit 6caf3dd2d6eb46fbc8ae1e8cd410d15b6f1a907e
4 changes: 1 addition & 3 deletions packages/tailwindcss/src/candidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,7 @@ export function parseCandidate(input: string, designSystem: DesignSystem): Candi
// If the leftover value is an empty string, it means that the value is an
// invalid named value. This makes the candidate invalid and we can
// skip any further parsing.
if (value === '') {
return null
}
if (value === '') return null

candidate.value = {
kind: 'named',
Expand Down