Add support for matching multiple utility definitions for one candidate #14231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
feat/v4-plugin-multiple-matches
branch
from
186d087 to
55afb14
Compare
philipp-spiess
changed the title
philipp-spiess
added a commit
that referenced
this pull request
Aug 27, 2024
…te (#14231) Currently if a plugin adds a utility called `duration` it will take precedence over the built-in utilities — or any utilities with the same name in previously included plugins. However, in v3, we emitted matches from _all_ plugins where possible. Take this plugin for example which adds utilities for `animation-duration` via the `duration-*` class: ```ts import plugin from 'tailwindcss/plugin' export default plugin( function ({ matchUtilities, theme }) { matchUtilities( { duration: (value) => ({ animationDuration: value }) }, { values: theme("animationDuration") }, ) }, { theme: { extend: { animationDuration: ({ theme }) => ({ ...theme("transitionDuration"), }), } }, } ) ``` Before this PR this plugin's `duration` utility would override the built-in `duration` utility so you'd get this for a class like `duration-3500`: ```css .duration-3000 { animation-duration: 3500ms; } ``` Now, after this PR, we'll emit rules for `transition-duration` (Tailwind's built-in `duration-*` utility) and `animation-duration` (from the above plugin) and you'll get this instead: ```css .duration-3000 { transition-duration: 3500ms; } .duration-3000 { animation-duration: 3500ms; } ``` These are output as separate rules to ensure that they can all be sorted appropriately against other utilities. --------- Co-authored-by: Philipp Spiess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a plugin adds a utility called
durationit will take precedence over the built-in utilities — or any utilities with the same name in previously included plugins. However, in v3, we emitted matches from all plugins where possible.Take this plugin for example which adds utilities for
animation-durationvia theduration-*class:Before this PR this plugin's
durationutility would override the built-indurationutility so you'd get this for a class likeduration-3500:Now, after this PR, we'll emit rules for
transition-duration(Tailwind's built-induration-*utility) andanimation-duration(from the above plugin) and you'll get this instead:These are output as separate rules to ensure that they can all be sorted appropriately against other utilities.