Improve the CLI output when nothing changed #14351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/improve-cli-output
branch
from
5ca1224 to
3344116
Compare
When we observe that no new candidates were found, we didn't write to disk because nothing really changed. There is also no need to re-optimize (minify / lightningcss) when nothing changed. But this had a side effect that when nothing changes that you didn't see any output. Typically you are changing things, so it's not really a problem. But the moment you use a class that already existed you also don't get any output because we have a shared cache. This improves that by always having some output.
RobinMalfait
force-pushed
the
feat/improve-cli-output
branch
from
3344116 to
30e840e
Compare
adamwathan
reviewed
Sep 5, 2024
Co-authored-by: Adam Wathan <[email protected]>
adamwathan
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we observe that no new candidates were found, then we can return early because nothing really changed. There is also no need to re-optimize (use Lightning CSS) in this case.
But this had a side effect that when no new candidates were detected, that you didn't see any output either. This feels like nothing is working from a DX perspective.
Typically you are changing things, so it's not really a problem. But the moment you use a class that already existed (e.g.: in another file) you also don't get any output because we have a shared cache.
This PR solves that by always showing the output. But it still doesn't write to disk if nothing changed.