Skip to content

Allow configs to override default CSS theme values in theme() function provided to plugins and configs #14359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 12 commits into from
Sep 6, 2024
Merged

Allow configs to override default CSS theme values in theme() function provided to plugins and configs #14359

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bba014c
Add failing test
adamwathan Sep 6, 2024
237c6de
WIP
RobinMalfait Sep 6, 2024
1efd997
WIP
RobinMalfait Sep 6, 2024
f99b8c5
make TypeScript happy
RobinMalfait Sep 6, 2024
98421d2
move tests around
RobinMalfait Sep 6, 2024
7a90d34
refactor `theme(…)`, simplify implementation
RobinMalfait Sep 6, 2024
26c98ec
adjust comments
RobinMalfait Sep 6, 2024
67daf9f
Correctly overwrite default theme tuple values
thecrypticace Sep 6, 2024
5f2851a
Simplify code
thecrypticace Sep 6, 2024
14555ea
Cleanup code
thecrypticace Sep 6, 2024
29dfe92
Apply suggestions from code review
adamwathan Sep 6, 2024
ffc9fed
Update changelog
adamwathan Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update changelog
  • Loading branch information
@adamwathan
adamwathan committed Sep 6, 2024
commit ffc9fedbebd31367d5aa84c90128d744d900994a
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Ensure there is always CLI feedback on save even when no new classes were found ([#14351](https://github.com/tailwindlabs/tailwindcss/pull/14351))
- Properly resolve `theme('someKey.DEFAULT')` when all `--some-key-*` keys have a suffix ([#14354](https://github.com/tailwindlabs/tailwindcss/pull/14354))
- Make sure tuple theme values in JS configs take precedence over `@theme default` values ([#14359](https://github.com/tailwindlabs/tailwindcss/pull/14359))

## [4.0.0-alpha.23] - 2024-09-05

Expand Down