Skip to content

Throw a useful error when tailwindcss is used as a PostCSS plugin #14378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipp-spiess merged 9 commits into from
Sep 11, 2024
+103 −11
Merged

Throw a useful error when tailwindcss is used as a PostCSS plugin #14378

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8745304
Throw a useful error when `tailwindcss` is used as a PostCSS plugin
philipp-spiess Sep 10, 2024
8c487d4
Add change log
philipp-spiess Sep 10, 2024
1e46f20
Remove leftover console.error reset
philipp-spiess Sep 10, 2024
56a841f
Unify wording in `*.cts` files
philipp-spiess Sep 10, 2024
e6e44c8
Export everything, not just the default export
philipp-spiess Sep 11, 2024
71eca3b
Patch the default export fn to contain the rest of the API
philipp-spiess Sep 11, 2024
c543d1d
Update packages/tailwindcss/src/index.ts
philipp-spiess Sep 11, 2024
8108134
Update tests to match the new wording
philipp-spiess Sep 11, 2024
568af8f
Make it pretty
philipp-spiess Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove leftover console.error reset
  • Loading branch information
@philipp-spiess
philipp-spiess committed Sep 10, 2024
commit 1e46f208c65d939fefe132f47b5c1caf419307b0
14 changes: 2 additions & 12 deletions integrations/postcss/core-as-postcss-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { afterEach, beforeEach } from 'node:test'
import { expect, vi } from 'vitest'
import { expect } from 'vitest'
import { css, js, json, test } from '../utils'

const variantConfig = {
Expand Down Expand Up @@ -30,16 +29,7 @@ const variantConfig = {
},
}

let originalConsoleError: typeof console.error
beforeEach(() => {
originalConsoleError = console.error
console.error = vi.fn()
})
afterEach(() => {
console.error = originalConsoleError
})

for (let variant of ['string', 'ESM', 'CJS']) {
for (let variant of Object.keys(variantConfig)) {
test(
`can not use \`tailwindcss\` as a postcss module (${variant})`,
{
Expand Down