-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Fix stacking variant order when variants inside a group are treated as equal #14431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
philipp-spiess
merged 13 commits into
next
from
fix/variant-order-for-variants-in-group
Sep 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d2870dc
Add failing test
philipp-spiess ec6edc4
Create a datastrucutre that groups equal entries so the bitmap can ra…
philipp-spiess 00af756
Sort by modifier if compound groups are equal
philipp-spiess f111b4b
Use array-of-sets
philipp-spiess 1f397ec
Avoid generating an iterator by retaining the last value
philipp-spiess bdf18ba
Make plugin-api test clearer
philipp-spiess d85cb2b
Add change log
philipp-spiess 7d77561
Update CHANGELOG.md
philipp-spiess 20885f0
Update comment
philipp-spiess 05d9ee7
Move sorting into DesignSystem
philipp-spiess 9700a1d
Fix changelog
philipp-spiess 00735aa
Use Map<Variant, number> instead (h/t @thecrypticace)
philipp-spiess 962590b
Variants inside variantOrderMap are exhaustive
philipp-spiess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Create a datastrucutre that groups equal entries so the bitmap can ra…
…nk equal entries the same way
- Loading branch information
commit ec6edc4161bbf5013551e4553d05b7c2ba4ac213
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were actually unordered before. If no custom order is provided, we now follow back to ordering the argument if everything else is the same, This will make
bakedappear beforeyellownow.