Explicitly ignore --inset-shadow and --inset-ring variables in inset handler#14447
Merged
adamwathan merged 4 commits intonextfrom Sep 18, 2024
Merged
Explicitly ignore --inset-shadow and --inset-ring variables in inset handler#14447adamwathan merged 4 commits intonextfrom
--inset-shadow and --inset-ring variables in inset handler#14447adamwathan merged 4 commits intonextfrom
Conversation
--inset-shadow and --inset-ring variables in inset handler--inset-shadow and --inset-ring variables in inset handler
9afa300 to
726fb42
Compare
philipp-spiess
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14440.
This PR fixes an issue where registering a custom
inset-shadow-*utility value in your theme like this:…mistakenly generates both an
inset-shadow-*andinset-*utility with that value:This replaces #14445 which turns out to not be the ideal solution.
Now we just explicitly ignore variables like
--inset-shadow-*and--inset-ring-*in theinsethandler. Kind of a gross patch but I can live with it because the whole existence of the--inset-*key is kind of a backwards compatibility thing anyways.