Ensure that @utility is top-level and cannot be nested
#14525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/ensure-at-utility-is-top-level
branch
from
3431264 to
e618f4c
Compare
1. Use a block / body 2. Ensure we return the `expect().rejects`
RobinMalfait
force-pushed
the
fix/ensure-at-utility-is-top-level
branch
from
e618f4c to
677a16e
Compare
RobinMalfait
requested review from
philipp-spiess and
thecrypticace
and removed request for
philipp-spiess
philipp-spiess
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where we expect the
@utilityto be top-level, but we didn't enforce it. This PR enforces that the@utilityis top-level.