Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also check for exceptions in modifier/variant arbitrary places
  • Loading branch information
philipp-spiess committed Sep 26, 2024
commit 6674b670453724c95a1c3ef7b3ea33c359e57969
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ export function automaticVarInjection(
if (
'modifier' in candidate &&
candidate.modifier?.kind === 'arbitrary' &&
candidate.modifier.value.startsWith('--')
candidate.modifier.value.startsWith('--') &&
!isAutomaticVarInjectionException(designSystem, candidate, candidate.modifier.value)
) {
candidate.modifier.value = `var(${candidate.modifier.value})`
didChange = true
Expand All @@ -24,7 +25,7 @@ export function automaticVarInjection(
//
// `supports-[--test]:flex'` => `supports-[var(--test)]:flex`
for (let variant of candidate.variants) {
let didChangeVariant = injectVarIntoVariant(variant)
let didChangeVariant = injectVarIntoVariant(designSystem, variant)
if (didChangeVariant) {
didChange = true
}
Expand Down Expand Up @@ -62,20 +63,25 @@ export function automaticVarInjection(
return null
}

function injectVarIntoVariant(variant: Variant): boolean {
function injectVarIntoVariant(designSystem: DesignSystem, variant: Variant): boolean {
let didChange = false
if (
variant.kind === 'functional' &&
variant.value &&
variant.value.kind === 'arbitrary' &&
variant.value.value.startsWith('--')
variant.value.value.startsWith('--') &&
!isAutomaticVarInjectionException(
designSystem,
createEmptyCandidate(variant),
variant.value.value,
)
) {
variant.value.value = `var(${variant.value.value})`
didChange = true
}

if (variant.kind === 'compound') {
let compoundDidChange = injectVarIntoVariant(variant.variant)
let compoundDidChange = injectVarIntoVariant(designSystem, variant.variant)
if (compoundDidChange) {
didChange = true
}
Expand All @@ -84,6 +90,18 @@ function injectVarIntoVariant(variant: Variant): boolean {
return didChange
}

function createEmptyCandidate(variant: Variant) {
return {
kind: 'arbitrary' as const,
property: 'color',
value: 'red',
modifier: null,
variants: [variant],
important: false,
raw: 'candidate',
}
}

const AUTO_VAR_INJECTION_EXCEPTIONS = new Set([
// Concrete properties
'scroll-timeline-name',
Expand Down