Fix rebuilds when editing imported CSS files #14561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Oct 1, 2024
Member
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Nice re. test upgrades
These tests make sure that changing an imported stylesheet results in a full rebuild by overriding some `@theme` values.
RobinMalfait
force-pushed
the
fix/watch-imported-css-files
branch
from
f66a4b4 to
590304e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where importing other CSS files, then changing those CSS files didn't trigger a rebuild. This PR fixes that by making sure that the imported CSS files are properly watched.
This PR also adds some integration tests for
@tailwindcss/postcss,@tailwindcss/viteand@tailwindcss/clito make sure this works as expected.