Add color-scheme utilities #14567
Merged
Add color-scheme utilities #14567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Luke Warlow <[email protected]>
Co-Authored-By: Luke Warlow <[email protected]>
philipp-spiess
approved these changes
Oct 2, 2024
Member
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Let's gooo! I’m glad we figured it all out 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #11271 — the merge conflicts are killing me and it's way easier to just do it again (added you as a co-author though @lukewarlow so you're still credited!)
This PR adds the following new utilities for the
color-schemeproperty:scheme-normalcolor-scheme: normalscheme-darkcolor-scheme: darkscheme-lightcolor-scheme: lightscheme-light-darkcolor-scheme: light darkscheme-only-darkcolor-scheme: dark onlyscheme-only-lightcolor-scheme: light onlyWent with
scheme-*for the utilities because there are currently no other CSS properties with the wordschemein them andscheme-light-darkis going to be a common value which is three words already even with the shortened property name.I considered setting
color-scheme: light darkby default as part of Preflight for this PR but decided against it, at least for this PR. I think that could still be a useful default but we should think about it a bit more because if you're building a light-mode-only site it'll force you to do some extra work.