Skip to content

Ensure font-stretch utilities only accepts positive integer bare values #14670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 2 commits into from
Oct 15, 2024
Merged

Ensure font-stretch utilities only accepts positive integer bare values #14670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93bcbb5
ensure `font-stretch-50.5%` does not compile
RobinMalfait Oct 15, 2024
825d90b
update changelog
RobinMalfait Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/tailwindcss/src/utilities.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11877,6 +11877,7 @@ test('font-stretch', async () => {
'font-stretch-20%',
'font-stretch-50',
'font-stretch-400%',
'font-stretch-50.5%',
'font-stretch-potato',
'font-stretch-ultra-expanded/foo',
'font-stretch-50%/foo',
Expand Down
1 change: 1 addition & 0 deletions packages/tailwindcss/src/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3146,6 +3146,7 @@ export function createUtilities(theme: Theme) {
handleBareValue: ({ value }) => {
if (!value.endsWith('%')) return null
let num = Number(value.slice(0, -1))
if (!isPositiveInteger(num)) return null
// Only 50-200% (inclusive) are valid:
// https://developer.mozilla.org/en-US/docs/Web/CSS/font-stretch#percentage
if (Number.isNaN(num) || num < 50 || num > 200) return null
Expand Down