Resolve theme keys when migrating JS config to CSS#14675
Merged
adamwathan merged 11 commits intonextfrom Oct 17, 2024
Merged
Conversation
d12009e to
bd66cec
Compare
34847f3 to
3456edd
Compare
Base automatically changed from
fix/reset-default-theme-values-for-non-extends-js-theme-config
to
next
October 16, 2024 14:06
56e01bd to
6c482c7
Compare
6c482c7 to
cb93881
Compare
thecrypticace
suggested changes
Oct 17, 2024
Contributor
thecrypticace
left a comment
There was a problem hiding this comment.
Looks good except for the test failures (color palette related). Fix those up and should be good to go.
thecrypticace
approved these changes
Oct 17, 2024
RobinMalfait
approved these changes
Oct 17, 2024
Member
RobinMalfait
left a comment
There was a problem hiding this comment.
Approved but some small changes
| @config '../tailwind.config.ts'; | ||
|
|
||
| @theme { | ||
| --color-gray-50: oklch(0.985 0 none); |
Member
There was a problem hiding this comment.
I know this PR didn't introduce it, but I wonder if the "legacy" colors (v3) should still use the v3 values (hex) instead of oklch(…) 🤔
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
adamwathan
approved these changes
Oct 17, 2024
adamwathan
reviewed
Oct 17, 2024
adamwathan
reviewed
Oct 17, 2024
adamwathan
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in #14672, it now becomes trivial to actually resolve the config (while still retaining the reset behavior). This means that we can now convert JS configs that use functions, e.g.:
This becomes: