Include simple config objects when extracting static plugins

[philipp-spiess]

This PR updates the extractStaticPlugins function to also emit options as long as these are objects containing of only string and number values.

While doing this I also cleaned up the require('custom-plugin') detector to use a Tree-Sitter query instead of operating on the AST.

Here are the two cases we considered:

import plugin1 from 'plugin1';

export default {
  plugins: [
    plugin1({
      foo: 'bar',
      num: 19,
    }),
    require('./plugin2')({
      foo: 'bar',
      num: 19,
    }),
  ]
}

The test plan also contains a number of scenarios that we do not want to migrate to CSS (because we do not have a CSS API we can use for e.g. nested objects). We do support all types that we also support in the CSS API.

[philipp-spiess]

• Migrate static plugins with options to CSS #14700
• Include simple config objects when extracting static plugins #14699 👈
• next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @philipp-spiess and the rest of your teammates on Graphite

[thecrypticace]

This reads like a typo rather than an intentional non-require call. Maybe like load or something?

[philipp-spiess]

Haha I had it call frequire before and I actually went in and fixed it since I thought it's a typo 🤕 agree i will just call it load so there's absolutely no confusion.

[adamwathan]

Should we add integration tests for this? It feels wrong to me that I can't look at any tests and see "given this config file, the equivalent generated CSS file is this".

Edit: Ah I think that's probably covered in the follow-up PR.

[thecrypticace]

Should we add integration tests for this? It feels wrong to me that I can't look at any tests and see "given this config file, the equivalent generated CSS file is this".

Those are in the followup PR where the actual CSS changes happen: #14700

[philipp-spiess]

Merge activity

• Oct 18, 9:10 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Oct 18, 9:10 AM EDT: A user merged this pull request with Graphite.