Skip to content

Run tests without optimization #14704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobinMalfait wants to merge 3 commits into from
Closed

Run tests without optimization #14704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bca2d23
run tests without optimizing
RobinMalfait Oct 17, 2024
63acf9a
use existing `run`, but with an `optimize` flag
RobinMalfait Oct 17, 2024
d5599c9
do not explicitly check for invalid attribute selectors
RobinMalfait Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/tailwindcss/src/test-utils/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ export async function compileCss(css: string, candidates: string[] = [], options
return optimizeCss(build(candidates)).trim()
}

export async function run(candidates: string[]) {
export async function run(candidates: string[], { optimize = true } = {}) {
Copy link
Contributor

@philipp-spiess philipp-spiess Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of having to add an object with optimize to every call site. How do you feel about this?

I’m wondering if we:

  • Should make this the default (or is the number of run() calls that do need optimize: true even larger than this subset?
  • Should instead add a second runOptimized export instead of adding a boolean variable?

Copy link
Contributor

@thecrypticace thecrypticace Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not a fan but not enough to really care. I think unoptimized is not the default. Pretty sure more tests require an optimized CSS result than not but I don't have a good idea of what the function should be called.

Copy link
Member Author

@RobinMalfait RobinMalfait Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny thing is, I did use a new method initially (14817cb) but run vs runOptimized or vs build all felt wrong, so did a fallback here because typically you run it without.

You could argue that we just don't run the tests through Lightning CSS (which will make the tests bigger but faster).

let { build } = await compile('@tailwind utilities;')
return optimizeCss(build(candidates)).trim()
let css = build(candidates)
return optimize ? optimizeCss(css).trim() : css.trim()
}

export function optimizeCss(
Expand Down
Loading