Skip to content

Upgrade: Migrate JS theme configuration keys with dot and slash in the property name #14736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 5 commits into from
Oct 22, 2024
Merged

Upgrade: Migrate JS theme configuration keys with dot and slash in the property name #14736

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47f75e8
Upgrade: Migrate JS theme configuration keys with dot and slash in th…
philipp-spiess Oct 21, 2024
e83f086
Update CHANGELOG.md
philipp-spiess Oct 22, 2024
c93676b
Merge branch '10-21-escape_js_theme_configuration_keys' into 10-21-up…
RobinMalfait Oct 22, 2024
d7d8cd1
Include -- prefix when escaping
adamwathan Oct 22, 2024
be5767e
Update CHANGELOG.md
adamwathan Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include -- prefix when escaping
  • Loading branch information
@adamwathan
adamwathan committed Oct 22, 2024
commit d7d8cd10de70b2c97f9d2d41bdc219ef0bef6379
4 changes: 2 additions & 2 deletions packages/@tailwindcss-upgrade/src/migrate-js-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,13 @@ async function migrateTheme(
resetNamespaces.set(key[0], true)
let property = keyPathToCssProperty([key[0]])
if (property !== null) {
css += ` --${escape(property)}-*: initial;\n`
css += ` ${escape(`--${property}`)}-*: initial;\n`
}
}

let property = keyPathToCssProperty(key)
if (property !== null) {
css += ` --${escape(property)}: ${value};\n`
css += ` ${escape(`--${property}`)}: ${value};\n`
}
}

Expand Down