-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Improve support for custom variants in group-*, peer-*, has-*, and not-* variants
#14743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d141afa
Add function for depth-first AST traversal
thecrypticace aa5fc87
Fix intellisense variant selector calculation
thecrypticace f8143a6
Add Intellisense API benchmark
thecrypticace 12b9fae
Use single rule for parallel variants when possible
thecrypticace 5b5bfc9
Add path information to `visit`
thecrypticace bc391bc
Simplify nesting checks in compound variants
thecrypticace 22673e5
Filter the kinds of rules compound variants support
thecrypticace 6a03a06
Register compound variants with the kinds of rules they support
thecrypticace 8dc719c
Let `not-*` variant handle simple conditional at rules
thecrypticace cc3e774
Update tests
thecrypticace 414bc16
Update changelog
thecrypticace 22e5614
Use bitfield enum
thecrypticace 9f1a7d3
Compute compounds when using staticVariant
thecrypticace 92e8d31
Add tests
thecrypticace fa3effb
Refactor
thecrypticace 9e365df
Compute compunds for arbitrary variants
thecrypticace 5b7e104
Compute compounds for `@variant`
thecrypticace 4cc3f16
Compute compounds for `addVariant`
thecrypticace fb0eabf
Add tests
thecrypticace a1ab176
Update CHANGELOG.md
thecrypticace 6ac6829
Apply suggestions from code review
thecrypticace a8ee1fb
Merge branch 'next' into feat/v4-not-tweaks
thecrypticace 48139ad
Update changelog
thecrypticace ba33ae0
Merge branch 'next' into feat/v4-not-tweaks
thecrypticace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add tests
- Loading branch information
commit 92e8d31796d4b69978863391ec1dbbf1eb845778
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.