Make config() path arg optional in v4 plugin API
#14799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Makes sense to me for this to work for BC 👍 |
adamwathan
requested changes
Oct 27, 2024
Member
adamwathan
left a comment
adamwathan
left a comment
There was a problem hiding this comment.
Just needs a changelog entry then can approve + merge 👍
adamwathan
reviewed
Oct 28, 2024
adamwathan
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14797
The
config()function in v3 had an optionalpathargument and when it wasn't provided it returned the resolved config directly so we need to do the same here.I've also added a
futurekey to the config objects / types.cc @adamwathan any objection to adding this or do you think we can get by without it?