Fix new file detection in PostCSS plugin #14829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/v4-new-file-detection
branch
from
5e9a595 to
8bd9176
Compare
things can run too fast apparently
RobinMalfait
approved these changes
Oct 30, 2024
Member
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Few small changes, but I like it.
| .filter_map(Result::ok) | ||
| } | ||
|
|
||
| #[tracing::instrument(skip(root))] |
Member
There was a problem hiding this comment.
Suggested change
| #[tracing::instrument(skip(root))] | |
| #[tracing::instrument(skip_all)] |
| read_dir(root, None) | ||
| } | ||
|
|
||
| #[tracing::instrument(skip(root))] |
Member
There was a problem hiding this comment.
Suggested change
| #[tracing::instrument(skip(root))] | |
| #[tracing::instrument(skip_all)] |
| .filter(|path| !known.contains(path)) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| modified_dirs.clear(); |
Member
There was a problem hiding this comment.
This is a bit cursed, I love it.
| static IGNORED_CONTENT_DIRS: sync::LazyLock<Vec<&'static str>> = | ||
| sync::LazyLock::new(|| vec![".git"]); | ||
|
|
||
| #[tracing::instrument(skip(root))] |
Member
There was a problem hiding this comment.
Suggested change
| #[tracing::instrument(skip(root))] | |
| #[tracing::instrument(skip_all)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke this at some point — probably when we tried to optimize rebuilds in PostCSS by not performing a full auto-source detection scan.
This PR addresses this problem by: