Skip to content

Install @tailwindcss/postcss next to tailwindcss #14830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 9 commits into from
Oct 30, 2024
Merged

Install @tailwindcss/postcss next to tailwindcss #14830

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e38d2c
add failing tests
RobinMalfait Oct 30, 2024
b713e0d
add package manager abstractions
RobinMalfait Oct 30, 2024
d1a9064
use new `pkg(base).add(…)` abstraction
RobinMalfait Oct 30, 2024
4dcd794
ensure we install `@tailwindcss/postcss` next to `tailwindcss`
RobinMalfait Oct 30, 2024
3b9e088
move `pkg(…)` to the top
RobinMalfait Oct 30, 2024
6f34059
only compute package manager once
RobinMalfait Oct 30, 2024
49ed09a
update changelog
RobinMalfait Oct 30, 2024
2a60d2c
Update integrations/upgrade/index.test.ts
RobinMalfait Oct 30, 2024
a8f54dd
simplify package manager code
RobinMalfait Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure we install @tailwindcss/postcss next to tailwindcss
  • Loading branch information
@RobinMalfait
RobinMalfait committed Oct 30, 2024
commit 4dcd794805cf8926ec2aa816a68980c0e97cf728
14 changes: 11 additions & 3 deletions packages/@tailwindcss-upgrade/src/migrate-postcss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,17 @@ export async function migratePostCSSConfig(base: string) {
}

if (didAddPostcssClient) {
try {
await pkg(base).add(['@tailwindcss/postcss@next'], 'devDependencies')
} catch {}
let location = Object.hasOwn(packageJson?.dependencies ?? {}, 'tailwindcss')
? ('dependencies' as const)
: Object.hasOwn(packageJson?.devDependencies ?? {}, 'tailwindcss')
? ('devDependencies' as const)
: null

if (location !== null) {
try {
await pkg(base).add(['@tailwindcss/postcss@next'], location)
} catch {}
}
}
if (didRemoveAutoprefixer || didRemovePostCSSImport) {
try {
Expand Down