Skip to content

Fix crash when using @source containing .. #14831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 14 commits into from
Oct 30, 2024
Merged

Fix crash when using @source containing .. #14831

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8674d46
canonicalize auto source base paths
RobinMalfait Oct 30, 2024
ee54ceb
add failing test
RobinMalfait Oct 30, 2024
916093e
add some `Safety` comments when using `unwrap()`
RobinMalfait Oct 30, 2024
0f90f71
use `Path` instead of `PathBuf`
RobinMalfait Oct 30, 2024
13e4f52
ignore stderr output
RobinMalfait Oct 30, 2024
cad8284
use `skip_all`
RobinMalfait Oct 30, 2024
3953681
update changelog
RobinMalfait Oct 30, 2024
8fa46a7
add failing test for absolute paths
RobinMalfait Oct 30, 2024
16c34b0
ensure absolute paths in patterns work
RobinMalfait Oct 30, 2024
7a157c2
Temp test win/mac CI
thecrypticace Oct 30, 2024
0fc63ca
Fix test on Windows
thecrypticace Oct 30, 2024
c218e10
Correctly detect absolute paths on Windows
thecrypticace Oct 30, 2024
cb87da9
Merge branch 'next' into fix/crash-when-using-source
thecrypticace Oct 30, 2024
ba3e8a1
Disable mac/win PR tests
thecrypticace Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Disable mac/win PR tests
  • Loading branch information
@thecrypticace
thecrypticace committed Oct 30, 2024
commit ba3e8a1cf0f60013eba7f4ffe83cd6a261953cdf
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
on-next-branch:
- ${{ github.ref == 'refs/heads/next' }}
exclude:
- on-next-branch: true
- on-next-branch: false
runner: windows-latest
- on-next-branch: true
- on-next-branch: false
runner: macos-14

runs-on: ${{ matrix.runner }}
Expand Down