Skip to content

Generate CSS after Vite handles imports during prod builds #14850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thecrypticace wants to merge 6 commits into from
Closed

Generate CSS after Vite handles imports during prod builds #14850

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a0701a
Add helper for writing binary files in integration tests
thecrypticace Oct 31, 2024
20685a3
Add failing test for Vite URL rewriting
thecrypticace Oct 31, 2024
35eb86d
Add test for `:deep(…)` in Vue scoped style blocks
thecrypticace Oct 31, 2024
53049e9
Generate CSS after Vite handles imports during prod builds
thecrypticace Oct 31, 2024
eb8ae52
Disable fix when using Lightning CSS
thecrypticace Oct 31, 2024
45da06c
Add stub test for lightningcss
thecrypticace Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add helper for writing binary files in integration tests
  • Loading branch information
@thecrypticace
thecrypticace committed Oct 31, 2024
commit 4a0701a1cd99799658441a354dac41d5d140ef04
18 changes: 14 additions & 4 deletions integrations/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ interface ExecOptions {

interface TestConfig {
fs: {
[filePath: string]: string
[filePath: string]: string | Uint8Array
}
}
interface TestContext {
Expand Down Expand Up @@ -279,8 +279,14 @@ export function test(
})
},
fs: {
async write(filename: string, content: string): Promise<void> {
async write(filename: string, content: string | Uint8Array): Promise<void> {
let full = path.join(root, filename)
let dir = path.dirname(full)
await fs.mkdir(dir, { recursive: true })

if (typeof content !== 'string') {
return await fs.writeFile(full, content)
}

if (filename.endsWith('package.json')) {
content = await overwriteVersionsInPackageJson(content)
Expand All @@ -291,8 +297,6 @@ export function test(
content = content.replace(/\n/g, '\r\n')
}

let dir = path.dirname(full)
await fs.mkdir(dir, { recursive: true })
await fs.writeFile(full, content)
},

Expand Down Expand Up @@ -494,6 +498,12 @@ export let json = dedent
export let yaml = dedent
export let txt = dedent

export function binary(str: string | TemplateStringsArray, ...values: unknown[]): Uint8Array {
let base64 = typeof str === 'string' ? str : String.raw(str, ...values)

return Uint8Array.from(atob(base64), (c) => c.charCodeAt(0))
}

export function candidate(strings: TemplateStringsArray, ...values: any[]) {
let output: string[] = []
for (let i = 0; i < strings.length; i++) {
Expand Down