Skip to content

Replace default explicit spacing scale with multiplier system #14857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 19 commits into from
Nov 5, 2024
Merged

Replace default explicit spacing scale with multiplier system #14857

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cd4d8c0
WIP (actual spacing multiplier stuff)
adamwathan Nov 1, 2024
90f5755
Update codemod tests
adamwathan Nov 1, 2024
00c1e0c
Add explicit tests for --spacing: initial
adamwathan Nov 2, 2024
a8c6805
Ensure bare spacing values are a multiple of 0.25
adamwathan Nov 2, 2024
e345199
Handle px values
adamwathan Nov 2, 2024
71c3832
Remove duplicate translate-px utilities
adamwathan Nov 2, 2024
7c4d2ca
Test leading zero is required for fractional bare spacing values
adamwathan Nov 2, 2024
503f45d
Remove spacing scale
adamwathan Nov 2, 2024
c97a31e
Derive numeric line height utilities from spacing scale
adamwathan Nov 2, 2024
a95be45
Update PostCSS plugin test
adamwathan Nov 3, 2024
a313895
Update tests
adamwathan Nov 4, 2024
08f522c
Limit spacing utilities that support fractions
adamwathan Nov 4, 2024
59aae3e
Update changelog
adamwathan Nov 4, 2024
c82e4f2
Update test
adamwathan Nov 4, 2024
4e536cd
Update test
adamwathan Nov 4, 2024
4013c47
Suggest original spacing scale by default
adamwathan Nov 5, 2024
02b4f8d
Don't support negative scroll padding
adamwathan Nov 5, 2024
5ac40b7
Merge branch 'next' into feat/spacing-multiplier
adamwathan Nov 5, 2024
466e137
Update tests
adamwathan Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test
  • Loading branch information
@adamwathan
adamwathan committed Nov 5, 2024
commit c82e4f201f2f5ce2194ea01034f5c7e8a5013f7d
4 changes: 2 additions & 2 deletions integrations/upgrade/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ test(
'src/index.html': html`
<h1>🤠👋</h1>
<div
class="!flex sm:!block bg-gradient-to-t bg-[--my-red] max-w-screen-md ml-[theme(spacing[1.5])]"
class="!flex sm:!block bg-gradient-to-t bg-[--my-red] max-w-screen-md ml-[theme(screens.md)]"
></div>
`,
'src/input.css': css`
Expand All @@ -93,7 +93,7 @@ test(
--- ./src/index.html ---
<h1>🤠👋</h1>
<div
class="flex! sm:block! bg-linear-to-t bg-[var(--my-red)] max-w-[var(--breakpoint-md)] ml-[var(--spacing-1_5)]"
class="flex! sm:block! bg-linear-to-t bg-[var(--my-red)] max-w-[var(--breakpoint-md)] ml-[var(--breakpoint-md)]"
Copy link
Member Author

@adamwathan adamwathan Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to something else until we work on the codemod for this new spacing stuff.

></div>

--- ./src/input.css ---
Expand Down