Rewrite urls in CSS files when using Vite#14877
Merged
adamwathan merged 10 commits intonextfrom Nov 7, 2024
Merged
Conversation
thecrypticace
force-pushed
the
fix/v4-url-rewriting
branch
from
2c978a3 to
2914209
Compare
Add stub test for lightningcss This fails so its marked as a `todo` test.
Co-authored-by: Philipp Spiess <hello@philippspiess.com>
RobinMalfait
force-pushed
the
fix/v4-url-rewriting
branch
from
2914209 to
9d25aad
Compare
Contributor
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Left some small notes but LGTM. I did co-author it with you tho so someone else should look over it 😄
Co-authored-by: Philipp Spiess <hello@philippspiess.com>
Co-authored-by: Philipp Spiess <hello@philippspiess.com>
adamwathan
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14784
This is an alternative to #14850 in which we actually perform url rewriting / rebasing ourselves. We ported a large portion of the URL-rewriting code from Vite (with attribution) to use here with some minor modifications. We've added test cases for the url rewriting so verifying individual cases is easy. We also wrote integration tests for Vite that use PostCSS and Lightning CSS that verify that files are found and inlined or relocated/renamed as necessary.
We also did some manual testing in the Playground to verify that this works as expected across several CSS files and directories which you can see a screenshot from here: