Add new ** variant
#14903
Merged
Add new ** variant
#14903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/add-any-children-variant
branch
from
a096a24 to
e43ccd1
Compare
This is very similar to `*`, the big difference is that: - `*` applies to direct children - `**` applies to any level of children Thought of this because of all the recent work we did around globs. So a good analogy for this is glob syntax where you have the exact same difference. `*.html` vs `**/*.html`.
RobinMalfait
force-pushed
the
feat/add-any-children-variant
branch
from
e43ccd1 to
08953a1
Compare
Contributor
thecrypticace
left a comment
thecrypticace
left a comment
There was a problem hiding this comment.
I'm a fan. Can we verify that Oxide picks this up?
Member
Author
@thecrypticace sure thing! Added an integration test: b1ab2b8 |
Contributor
|
cool — I was kinda just thinking adding the test to the Rust suite but this works too! |
thecrypticace
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
**variant to target any level of children.This is very similar to the
*variant, the big difference is that:*applies to direct children only**applies to any level of childrenThought of this because of all the recent work we did around globs. So a good analogy for this is glob syntax where you have the exact same difference.
*.htmlvs**/*.html.