Skip to content

Increase specificity of * and ** variants #14920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 3 commits into from
Nov 8, 2024
Merged

Increase specificity of * and ** variants #14920

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5300a2
reduce specificity of `*` and `**` variants
RobinMalfait Nov 8, 2024
a4977d9
update changelog
RobinMalfait Nov 8, 2024
867bb7e
Update CHANGELOG.md
adamwathan Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
reduce specificity of * and ** variants
  • Loading branch information
@RobinMalfait @adamwathan
RobinMalfait authored and adamwathan committed Nov 8, 2024
commit c5300a2f7142bf3b77586eea579a137164a116c0
4 changes: 2 additions & 2 deletions packages/tailwindcss/src/variants.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test('force', async () => {

test('*', async () => {
expect(await run(['*:flex'])).toMatchInlineSnapshot(`
":where(.\\*\\:flex > *) {
":is(.\\*\\:flex > *) {
display: flex;
}"
`)
Expand All @@ -26,7 +26,7 @@ test('*', async () => {

test('**', async () => {
expect(await run(['**:flex'])).toMatchInlineSnapshot(`
":where(.\\*\\*\\:flex *) {
":is(.\\*\\*\\:flex *) {
display: flex;
}"
`)
Expand Down
4 changes: 2 additions & 2 deletions packages/tailwindcss/src/variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ export function createVariants(theme: Theme): Variants {
}

variants.static('force', () => {}, { compounds: Compounds.Never })
staticVariant('*', [':where(& > *)'], { compounds: Compounds.Never })
staticVariant('**', [':where(& *)'], { compounds: Compounds.Never })
staticVariant('*', [':is(& > *)'], { compounds: Compounds.Never })
staticVariant('**', [':is(& *)'], { compounds: Compounds.Never })

function negateConditions(ruleName: string, conditions: string[]) {
return conditions.map((condition) => {
Expand Down