Convert , to in grid-cols-[…], grid-rows-[…], and object-[…]#14927
Merged
adamwathan merged 4 commits intonextfrom Nov 11, 2024
Merged
Convert , to in grid-cols-[…], grid-rows-[…], and object-[…]#14927adamwathan merged 4 commits intonextfrom
, to in grid-cols-[…], grid-rows-[…], and object-[…]#14927adamwathan merged 4 commits intonextfrom
Conversation
RobinMalfait
changed the title
, to in legacy arbitrary values, to in grid-cols-[…], grid-rows-[…], and object-[…]
RobinMalfait
force-pushed
the
fix/migrate-comma-to-spaces
branch
from
e4ec750 to
590d3f5
Compare
philipp-spiess
approved these changes
Nov 11, 2024
Contributor
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Awesome! Great to see the impact on this on Catalyst in your test plan 😎
CHANGELOG.md
Outdated
| - _Upgrade (experimental)_: Remove whitespace around `,` separator when print arbitrary values ([#14838](https://github.com/tailwindlabs/tailwindcss/pull/14838)) | ||
| - _Upgrade (experimental)_: Fix crash during upgrade when content globs escape root of project ([#14896](https://github.com/tailwindlabs/tailwindcss/pull/14896)) | ||
| - _Upgrade (experimental)_: Don't convert `theme(…/15%)` to modifier unless it is the entire arbitrary value of a utility ([#14922](https://github.com/tailwindlabs/tailwindcss/pull/14922)) | ||
| - _Upgrade (experimental)_: Convert `,` to ` ` in `grid-cols-[…]`, `grid-rows-[…]`, and `object-[…]` ([#14927](https://github.com/tailwindlabs/tailwindcss/pull/14927)) |
Contributor
There was a problem hiding this comment.
Maybe this is a tid bit clearer?
Suggested change
| - _Upgrade (experimental)_: Convert `,` to ` ` in `grid-cols-[…]`, `grid-rows-[…]`, and `object-[…]` ([#14927](https://github.com/tailwindlabs/tailwindcss/pull/14927)) | |
| - _Upgrade (experimental)_: Convert `,` to ` ` in arbitrary values of `grid-cols-[…]`, `grid-rows-[…]`, and `object-[…]` ([#14927](https://github.com/tailwindlabs/tailwindcss/pull/14927)) |
adamwathan
reviewed
Nov 11, 2024
adamwathan
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts legacy commas in arbitrary values to spaces.
In Tailwind CSS v3, we allowed commas in arbitrary values for
grid-cols-[…],grid-rows-[…], andobject-[…]for backwards compatibility. The underlying CSS value did use spaces instead of commas.This PR adds a code mod where convert the commas to spaces when we see them.
Test plan:
Running this on Catalyst it goes from this:
To the expected value of: