Bring back named opacity support for color opacity modifiers #15009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
reviewed
Nov 15, 2024
adamwathan
reviewed
Nov 15, 2024
playgrounds/vite/src/app.tsx
Outdated
| export function App() { | ||
| return ( | ||
| <div className="m-3 p-3 border"> | ||
| <div className="m-3 p-3 border bg-red-500/mymy"> |
Member
There was a problem hiding this comment.
Can remove these playground files from the diff 👍
adamwathan
approved these changes
Nov 15, 2024
Member
adamwathan
left a comment
adamwathan
left a comment
There was a problem hiding this comment.
Good to merge after undoing those playground changes 👍
Co-authored-by: Adam Wathan <[email protected]>
philipp-spiess
force-pushed
the
feat/bring-back-named-opacity-support
branch
from
7e3f119 to
06609ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #14278 to bring back support for using named opacity values in color opacity modifiers:
We briefly discuss to restructure the code so that we avoid adding a
themeargument to the call sites but I do still prefer the current approach for the following reasons: The way to avoid this is to a) put something in either theThemeclass scope, where it feels grossly out of place, or b) put it into the shared closure in the utilities file which is already very large and hard to reason. Furthermore, there's a second call site in the compile function where we would need to duplicate the namespace lookup.Every caller of the current
asColorvalue already has access to theThemeso passing that as an argument seems like the least intrusive way.Test Plan
Brought back the unit tests but I also tested it with the Vite extension: