Skip to content

Upgrade: Error when project is already using Tailwind CSS v4 #15015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 7 commits into from
Nov 19, 2024
Merged

Upgrade: Error when project is already using Tailwind CSS v4 #15015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8588d07
Upgrade: Error when project is already using Tailwind CSS v4
philipp-spiess Nov 15, 2024
ba940d1
Apply feedback
philipp-spiess Nov 18, 2024
67fd4fb
Use `createRequire()`
philipp-spiess Nov 18, 2024
edcd0c8
Apply suggestions from code review
philipp-spiess Nov 18, 2024
71ce1fa
Add change log
philipp-spiess Nov 18, 2024
10e2616
move Tailwind version check outside of `--force` check
RobinMalfait Nov 18, 2024
1ca1412
ensure Tailwind CSS v3 is used
RobinMalfait Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Robin Malfait <[email protected]>
  • Loading branch information
@philipp-spiess @RobinMalfait
philipp-spiess and RobinMalfait committed Nov 18, 2024
commit edcd0c834debc75bc1d9683176f45089d7a93037
2 changes: 1 addition & 1 deletion integrations/upgrade/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2464,7 +2464,7 @@ test(
},
)

test.only(
test(
'requires Tailwind v3 before attempting an upgrade',
{
fs: {
Expand Down
1 change: 0 additions & 1 deletion packages/@tailwindcss-upgrade/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ async function run() {

// Require an installed `tailwindcss` version < 4
let tailwindVersion = await getPackageVersion('tailwindcss', base)
console.error({ tailwindVersion })
if (tailwindVersion && Number(tailwindVersion.split('.')[0]) !== 3) {
error(
`Tailwind CSS v${tailwindVersion} found. The migration tool can only be run on v3 projects.`,
Expand Down