Skip to content

Upgrade: don't show error during upgrade when analyzing external URL import #15040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 5 commits into from
Nov 19, 2024
Merged

Upgrade: don't show error during upgrade when analyzing external URL import #15040

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2be06da
do not show error when analyzing external URL imports
RobinMalfait Nov 19, 2024
2f7e076
ignore errors, and skip handling `@import`
RobinMalfait Nov 19, 2024
e94eac4
remove unused code
RobinMalfait Nov 19, 2024
07fb937
add import with external URL
RobinMalfait Nov 19, 2024
973b93b
update changelog
RobinMalfait Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/@tailwindcss-upgrade/src/migrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ export async function analyze(stylesheets: Stylesheet[]) {
resolvedPath = resolveCssId(id, basePath)
}
} catch (err) {
// Import is a URL, we don't want to process these, but also don't
// want to show an error message for them.
if (id.startsWith('http://') || id.startsWith('https://') || id.startsWith('//')) {
return
}

// Something went wrong, we can't resolve the import.
error(
`Failed to resolve import: ${highlight(id)} in ${highlight(relative(node.source?.input.file!, basePath))}. Skipping.`,
{ prefix: '↳ ' },
Expand Down