Skip to content

Fix scanning classes delimited by tab characters #15169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 8 commits into from
Nov 26, 2024
Merged

Fix scanning classes delimited by tab characters #15169

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7debe3c
format parser
RobinMalfait Nov 25, 2024
580977b
add failing integration test
RobinMalfait Nov 25, 2024
150bde0
add failing test
RobinMalfait Nov 25, 2024
74dcd3b
skip all whitespace
RobinMalfait Nov 25, 2024
c3e044e
update changelog
RobinMalfait Nov 25, 2024
9329d57
add dedicated tests with different whitespace (none, spaces, tabs and…
RobinMalfait Nov 25, 2024
3177231
improve reproduction integration tests
RobinMalfait Nov 25, 2024
7ec2bf8
drop integration tests
RobinMalfait Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
format parser
  • Loading branch information
@RobinMalfait
RobinMalfait committed Nov 26, 2024
commit 7debe3ceee0cc316cc79656fae36fdf039c84ca9
19 changes: 3 additions & 16 deletions crates/oxide/src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,7 @@ impl<'a> Extractor<'a> {

// Reject candidates that are single camelCase words, e.g.: `useEffect`
if candidate.iter().all(|c| c.is_ascii_alphanumeric())
&& candidate
.iter()
.any(|c| c.is_ascii_uppercase())
&& candidate.iter().any(|c| c.is_ascii_uppercase())
{
return ValidationResult::Invalid;
}
Expand Down Expand Up @@ -1542,18 +1540,7 @@ mod test {

#[test]
fn simple_utility_names_with_numbers_work() {
let candidates = run(
r#"<div class="h2 hz"></div>"#,
false,
);
assert_eq!(
candidates,
vec![
"div",
"class",
"h2",
"hz",
]
);
let candidates = run(r#"<div class="h2 hz"></div>"#, false);
assert_eq!(candidates, vec!["div", "class", "h2", "hz",]);
}
}