Skip to content

Improve performance of scanning source files #15270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 7 commits into from
Dec 2, 2024
Merged

Improve performance of scanning source files #15270

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d3da40
only check for new files in subsequent builds
RobinMalfait Dec 2, 2024
5c4a4ff
use `par_sort` and `into_part_iter`
RobinMalfait Dec 2, 2024
e5a64c5
run the extractor on very small chunks, split by whitespace
RobinMalfait Dec 2, 2024
e99f276
update changelog
RobinMalfait Dec 2, 2024
8fe3977
only split by newlines
RobinMalfait Dec 2, 2024
abd6c8f
only split on newlines
RobinMalfait Dec 2, 2024
cb8a7d7
Update CHANGELOG.md
adamwathan Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only split by newlines 
To reduce overhead of the Extractor itself, we can chunk the work by
lines instead of every whitespace-separated chunk.

This seems to improve the overall cost even more!

Co-authored-by: Jordan Pittman <[email protected]>
  • Loading branch information
@RobinMalfait @thecrypticace
RobinMalfait and thecrypticace committed Dec 2, 2024
commit 8fe397717d11e85737220049ebc8fcdc02744628
2 changes: 1 addition & 1 deletion crates/oxide/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ fn read_all_files(changed_content: Vec<ChangedContent>) -> Vec<Vec<u8>> {
fn parse_all_blobs(blobs: Vec<Vec<u8>>) -> Vec<String> {
let mut result: Vec<_> = blobs
.par_iter()
.flat_map(|blob| blob.par_split(|x| x.is_ascii_whitespace()))
.flat_map(|blob| blob.par_split(|x| matches!(x, b'\n' | b'\r')))
.map(|blob| Extractor::unique(blob, Default::default()))
.reduce(Default::default, |mut a, b| {
a.extend(b);
Expand Down