Vite: Don't rebase absolute url()s
#15275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
fix/dont-rebase-absolute-urls
branch
from
ed1ce34 to
0b65e24
Compare
thecrypticace
approved these changes
Dec 2, 2024
thecrypticace
changed the title
url()url()s
philipp-spiess
added a commit
that referenced
this pull request
Dec 3, 2024
I noticed uncommitted changes of #15275 on my local setup so here's the updated changelog and the added unit test.
|
Thank you for fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15269
This PR fixes an issue where our Vite extension was rebasing absolute urls inside
@import-ed files. We forgot to cover this when we implemented the URL rebasing.Test Plan
We validated that this fixes the repro in #15269:
Also added a unit test for this.