Skip to content

Use AST transformations in @tailwindcss/postcss #15297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipp-spiess merged 25 commits into from
Dec 4, 2024
Merged

Use AST transformations in @tailwindcss/postcss #15297

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a5407e3
allow to pass in the `!important` flag
RobinMalfait Dec 3, 2024
29cc49d
implement `postCssAstToCssAst` and `cssAstToPostCssAst`
RobinMalfait Dec 3, 2024
94aeeab
optimize AST before printing
RobinMalfait Dec 3, 2024
7eefb19
implement new `compileAst(…)` and update `compile(…)`
RobinMalfait Dec 3, 2024
531670b
expose `compileAst` from `@tailwindcss/node`
RobinMalfait Dec 3, 2024
6cabeea
WIP: PostCSS implementation
RobinMalfait Dec 3, 2024
42401b4
Tweak code
thecrypticace Dec 3, 2024
0e954b2
Convert our AST to PostCSS’s AST
thecrypticace Dec 3, 2024
79cadb8
Pass through source information
thecrypticace Dec 3, 2024
2adaf42
print CSS from our own AST
RobinMalfait Dec 4, 2024
ef17c45
only convert our AST into a PostCSS AST when not optimizing
RobinMalfait Dec 4, 2024
f006e36
remove unused variable
RobinMalfait Dec 4, 2024
709947c
rename variables to be more explicit
RobinMalfait Dec 4, 2024
a4df476
add timing info around `cssAstToPostCssAst(…)`
RobinMalfait Dec 4, 2024
71c1c0d
restructure `build(…)`
RobinMalfait Dec 4, 2024
a24e4c4
track the `tailwindCssAst` for subsequent cache hits
RobinMalfait Dec 4, 2024
260beed
ensure PostCSS AST nodes have semicolons
RobinMalfait Dec 4, 2024
87065a8
handle comments correctly
RobinMalfait Dec 4, 2024
3de1864
compute current_mtimes in parallel per file/directory
RobinMalfait Dec 4, 2024
98f66cb
remove instrumentation from `read_dir`
RobinMalfait Dec 4, 2024
84bde5e
trick PostCSS into using 2 spaces instead of 4
RobinMalfait Dec 4, 2024
7aeea03
use `??=` shorthand
RobinMalfait Dec 4, 2024
1a04957
ensure `compile` and `compileAst` re-use the same logic
RobinMalfait Dec 4, 2024
5f22986
run format
RobinMalfait Dec 4, 2024
c5c7c9f
clone the cached PostCSS tree before appending it to the root
RobinMalfait Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove instrumentation from read_dir
  • Loading branch information
@RobinMalfait
RobinMalfait committed Dec 4, 2024
commit 98f66cbc487a47b714b056c4e4f42c8fd2f4816b
1 change: 0 additions & 1 deletion crates/oxide/src/scanner/allowed_paths.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ pub fn resolve_paths(root: &Path) -> impl Iterator<Item = DirEntry> {
.filter_map(Result::ok)
}

#[tracing::instrument(skip_all)]
pub fn read_dir(root: &Path, depth: Option<usize>) -> impl Iterator<Item = DirEntry> {
WalkBuilder::new(root)
.hidden(false)
Expand Down