Don’t detect arbitrary properties when preceded by an escape #15456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
Member
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Looks good but the test needs a proper title 👍
crates/oxide/src/parser.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn wip2() { |
Contributor
Author
There was a problem hiding this comment.
oh yeah lol good call
crates/oxide/src/parser.rs
Outdated
| #[inline(always)] | ||
| fn parse_char(&mut self) -> ParseAction<'a> { | ||
| if !matches!(self.arbitrary, Arbitrary::None) { | ||
| if !matches!(self.arbitrary, Arbitrary::None) { |
Member
There was a problem hiding this comment.
Not sure what happened here? 🤔
| match self.cursor.curr { | ||
| // Enter arbitrary property mode | ||
| b'[' => { | ||
| b'[' if self.cursor.prev != b'\\' => { |
RobinMalfait
approved these changes
Dec 20, 2024
philipp-spiess
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a targeted bug fix uncovered by the v4 docs.
Given this code:
<!-- [!code word:group-has-\\[a\\]\\:block] -->We'd pick up
[a\\]\\:block]as a candidate which would then make it far enough to get output to CSS and throw an error. This makes sure we don't try to start an arbitrary property if the preceding character is a\cc @RobinMalfait this look okay?