Skip to content

Implement @variant #15663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 7 commits into from
Jan 21, 2025
Merged

Implement @variant #15663

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f010bb7
use `@custom-variant` instead of `@variant`
RobinMalfait Jan 17, 2025
937eff4
flatten `&` rules
RobinMalfait Jan 17, 2025
6b5b085
implement `@variant`
RobinMalfait Jan 17, 2025
27fa0b8
track 'custom-variant'
RobinMalfait Jan 17, 2025
bab1ee3
use correct `@tw-bucket` for sorting
RobinMalfait Jan 17, 2025
26c9e96
only allow a single variant
RobinMalfait Jan 20, 2025
2828c7c
validate `@custom-variant`'s name
RobinMalfait Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use correct @tw-bucket for sorting
  • Loading branch information
@RobinMalfait
RobinMalfait committed Jan 20, 2025
commit bab1ee3101656cde44926efc425ab19da984efdf
2 changes: 1 addition & 1 deletion packages/@tailwindcss-upgrade/src/migrate-js-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ function migrateDarkMode(unresolvedConfig: Config & { darkMode: any }): string {
if (variant === '') {
return ''
}
return `\n@tw-bucket variant {\n@custom-variant dark (${variant});\n}\n`
return `\n@tw-bucket custom-variant {\n@custom-variant dark (${variant});\n}\n`
}

// Returns a string identifier used to section theme declarations
Expand Down