Skip to content

Prevent not-* from being used with variants with multiple sibling rules #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 5 commits into from
Jan 21, 2025
Merged

Prevent not-* from being used with variants with multiple sibling rules #15689

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c80f4f5
Fix tests
thecrypticace Jan 21, 2025
dee4cfc
Don’t allow `not` to be used with variants that have siblings
thecrypticace Jan 21, 2025
84e46c6
Update changelog
thecrypticace Jan 21, 2025
dbab546
tweak changelog
thecrypticace Jan 21, 2025
0079a81
Update changelog
thecrypticace Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix tests
  • Loading branch information
@thecrypticace
thecrypticace committed Jan 21, 2025
commit c80f4f513de6798d495cc402f002f869580d8a56
22 changes: 11 additions & 11 deletions packages/tailwindcss/src/variants.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,19 +1664,19 @@ test('not', async () => {
// there is no sensible negative version of them.

// These just don't make sense as not-*
'not-force',
'not-*',
'not-force:flex',
'not-*:flex',

// These contain pseudo-elements
'not-first-letter',
'not-first-line',
'not-marker',
'not-selection',
'not-file',
'not-placeholder',
'not-backdrop',
'not-before',
'not-after',
'not-first-letter:flex',
'not-first-line:flex',
'not-marker:flex',
'not-selection:flex',
'not-file:flex',
'not-placeholder:flex',
'not-backdrop:flex',
'not-before:flex',
'not-after:flex',

// This is not a conditional at rule
'not-starting:flex',
Expand Down