Skip to content

Prevent modifying CSS variables in plugins #16103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 5 commits into from
Jan 31, 2025
Merged

Prevent modifying CSS variables in plugins #16103

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
578a63d
prevent modifying CSS variables in plugins
siriwatknp Jan 31, 2025
be267f6
small refactor: only check for `--` once
RobinMalfait Jan 31, 2025
2006445
update changelog
RobinMalfait Jan 31, 2025
875268e
Update CHANGELOG.md
RobinMalfait Jan 31, 2025
bf1fe35
Update CHANGELOG.md
RobinMalfait Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
small refactor: only check for -- once
  • Loading branch information
@RobinMalfait
RobinMalfait committed Jan 31, 2025
commit be267f61c81d252cd22f562c317a15fb019846eb
17 changes: 9 additions & 8 deletions packages/tailwindcss/src/compat/plugin-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,17 +499,18 @@ export function objectToAst(rules: CssInJs | CssInJs[]): AstNode[] {

for (let [name, value] of entries) {
if (typeof value !== 'object') {
if (!name.startsWith('--') && value === '@slot') {
ast.push(rule(name, [atRule('@slot')]))
} else {
if (!name.startsWith('--')) {
// Convert camelCase to kebab-case:
// https://github.com/postcss/postcss-js/blob/b3db658b932b42f6ac14ca0b1d50f50c4569805b/parser.js#L30-L35
name = name.replace(/([A-Z])/g, '-$1').toLowerCase()
if (!name.startsWith('--')) {
if (value === '@slot') {
ast.push(rule(name, [atRule('@slot')]))
continue
}

ast.push(decl(name, String(value)))
// Convert camelCase to kebab-case:
// https://github.com/postcss/postcss-js/blob/b3db658b932b42f6ac14ca0b1d50f50c4569805b/parser.js#L30-L35
name = name.replace(/([A-Z])/g, '-$1').toLowerCase()
}

ast.push(decl(name, String(value)))
} else if (Array.isArray(value)) {
for (let item of value) {
if (typeof item === 'string') {
Expand Down