Skip to content

Do not emit empty rules/at-rules #16121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 9 commits into from
Jan 31, 2025
Merged

Do not emit empty rules/at-rules #16121

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d73a187
do not emit empty rules
RobinMalfait Jan 31, 2025
3d8db39
do not emit empty at-rules
RobinMalfait Jan 31, 2025
e635954
update tests to remove empty rules and at-rules
RobinMalfait Jan 31, 2025
356d0c5
add dedicated optimization test
RobinMalfait Jan 31, 2025
268487d
update changelog
RobinMalfait Jan 31, 2025
2396d9c
remove empty rules from integration tests
RobinMalfait Jan 31, 2025
f7f38a8
Update packages/tailwindcss/src/ast.ts
RobinMalfait Jan 31, 2025
92c2d1c
add `@namespace` edge case to tests
RobinMalfait Jan 31, 2025
8e6fe3b
use double quotes for `@charset`
RobinMalfait Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/tailwindcss/src/ast.ts 
Co-authored-by: Jordan Pittman <[email protected]>
  • Loading branch information
@RobinMalfait @thecrypticace
RobinMalfait and thecrypticace committed Jan 31, 2025
commit f7f38a84b5b57497763912d887e59e0692a194d5
3 changes: 2 additions & 1 deletion packages/tailwindcss/src/ast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ export function optimizeAst(ast: AstNode[]) {
copy.nodes.length > 0 ||
copy.name === '@layer' ||
copy.name === '@charset' ||
copy.name === '@custom-media'
copy.name === '@custom-media' ||
copy.name === '@namespace'
Copy link
Member

@philipp-spiess philipp-spiess Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be all at-rules? 🤔 Nevermind me here

Copy link
Member Author

@RobinMalfait RobinMalfait Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

@media (foo) {}

Should be removed imo

Copy link
Member

@philipp-spiess philipp-spiess Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i noticed this too, you just responded before i could update my comment heh

Copy link
Member Author

@RobinMalfait RobinMalfait Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, I think in theory we could invert the condition and don't touch everything but the @media (but then we need to check for @suspports as well.

In a perfect world @layer foo {} is also removed, (because you should use @layer foo; but we don't make that distinction.

) {
parent.push(copy)
}
Expand Down