Skip to content

Upgrade: Handle darkMode value with block syntax #16507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipp-spiess merged 4 commits into from
Feb 14, 2025
Merged

Upgrade: Handle darkMode value with block syntax #16507

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4f9246
Upgrade: Handle `darkMode` value with block syntax
philipp-spiess Feb 13, 2025
7cbc669
Merge branch 'main' into fix/allow-curly-braces-in-js-theme-darkMode-…
philipp-spiess Feb 13, 2025
6176421
Upgrade: Handle `darkMode` value with block syntax
philipp-spiess Feb 13, 2025
7f5c46a
Properly handle arrays
philipp-spiess Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Upgrade: Handle darkMode value with block syntax
  • Loading branch information
@philipp-spiess
philipp-spiess committed Feb 13, 2025
commit 6176421eca9a81c7ac5afc8af2481fbd861f53d1
8 changes: 8 additions & 0 deletions integrations/upgrade/js-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,14 @@ test(
is-arr-mixed: null, true, false, 1234567, 1.35, 'foo', 'bar', 'true';
}

@custom-variant dark {
@media not print {
.dark & {
@slot;
}
}
}

/*
The default border color has changed to \`currentColor\` in Tailwind CSS v4,
so we've added these compatibility styles to make sure everything still
Expand Down