Skip to content

Fix variants with <digit>.</digit> are extracted correctly #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 5 commits into from
Mar 12, 2025
+19 −12
Merged

Fix variants with <digit>.</digit> are extracted correctly #17153

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfa0455
add failing test
RobinMalfait Mar 12, 2025
7c82e08
allow `.` if surrounded by numbers
RobinMalfait Mar 12, 2025
d551180
remove unused classifications
RobinMalfait Mar 12, 2025
7cd21db
update changelog
RobinMalfait Mar 12, 2025
0c93235
update comment
RobinMalfait Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused classifications
  • Loading branch information
@RobinMalfait
RobinMalfait committed Mar 12, 2025
commit d55118063f3f17a647e0598c158628ee54ed4d71
12 changes: 0 additions & 12 deletions crates/oxide/src/extractor/named_variant_machine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,24 +341,15 @@ enum Class {
#[bytes(b'.')]
Dot,

#[bytes(b'\0')]
End,

#[bytes_range(b'0'..=b'9')]
Number,

#[bytes(b'[')]
OpenBracket,

#[bytes(b']')]
CloseBracket,

#[bytes(b'(')]
OpenParen,

#[bytes(b'\'', b'"', b'`')]
Quote,

#[bytes(b'*')]
Star,

Expand All @@ -368,9 +359,6 @@ enum Class {
#[bytes(b'_')]
Underscore,

#[bytes(b' ', b'\t', b'\n', b'\r', b'\x0C')]
Whitespace,

#[fallback]
Other,
}
Expand Down