Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@source notsupport #17255New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Add
@source notsupport #17255Changes from 1 commit
ff98e6d18442be22bd00fba153be72b18cdcd6ccb2324569c335e9e188a6048602a80197986379958612878782ea7bef4e8d154d138ed37e0f7379797fc4bf94473d37442baa2425aefbb0610d6952871b6ab98f5e7d0359d4c2afFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
The gist of it is that we now are dealing with `SourceEntry` instead of `GlobEntry`. A `SourceEntry` in the `node` crate maps to a `PublicSourceEntry`. This makes it easy for JS APIs to pass in the values. A `PublicSourceEntry` looks like: - `base` — the base path of the source - `pattern` — the glob pattern - `negated` — whether or not the pattern should be negated Internally we will map this to a `SourceEntry`, this is a proper enum that looks like this: ```rs pub enum SourceEntry { Auto { base: PathBuf }, IgnoredAuto { base: PathBuf }, Pattern { base: PathBuf, pattern: String }, IgnoredPattern { base: PathBuf, pattern: String }, } ``` Before we construct a Scanner, we will also make sure to optimize these patterns. Some optimization steps: 1. Each `pattern` will be brace-expanded and a new `SourceEntry` will be created. This allows us to always deal with simple patterns. 2. The `base` of each `SourceEntry` will be canonicalized so we are dealing with the real paths and symlinks are resolved. 3. When patterns include static parts such as `/src/*.html`, then the static part (in this case `src`) will be moved to the `base`.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing