Skip to content

Fix slow incremental builds (especially on Windows) #17511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 10 commits into from
Apr 3, 2025
+170 −9
Merged

Fix slow incremental builds (especially on Windows) #17511

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d996004
fix typo
RobinMalfait Apr 3, 2025
74ce2a0
catch errors in case `fs.rm` doesn't work
RobinMalfait Apr 2, 2025
0a0f80d
add failing integration test
RobinMalfait Apr 3, 2025
a63b1fa
do not use mutable self
RobinMalfait Apr 3, 2025
c80631d
use cached `self.globs`
RobinMalfait Apr 3, 2025
9ab12c4
skip scanning ignored content dirs
RobinMalfait Apr 3, 2025
0622765
update changelog
RobinMalfait Apr 3, 2025
223b246
drop the parens
RobinMalfait Apr 3, 2025
71557e6
Merge branch 'main' into fix/slow-scans
RobinMalfait Apr 3, 2025
e2c01e3
Merge branch 'main' into fix/slow-scans
RobinMalfait Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
catch errors in case fs.rm doesn't work
  • Loading branch information
@RobinMalfait
RobinMalfait committed Apr 3, 2025
commit 74ce2a064781c293f4126705181214cdf90f26ee
4 changes: 3 additions & 1 deletion integrations/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,8 @@ export async function fetchStyles(base: string, path = '/'): Promise<string> {
async function gracefullyRemove(dir: string) {
// Skip removing the directory in CI because it can stall on Windows
if (!process.env.CI) {
await fs.rm(dir, { recursive: true, force: true })
await fs.rm(dir, { recursive: true, force: true }).catch((error) => {
console.log(`Failed to remove ${dir}`, error)
})
}
}