Skip to content

Fix race condition in Next.js with --turbopack #17514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipp-spiess merged 6 commits into from
Apr 3, 2025
+82 −15
Merged

Fix race condition in Next.js with --turbopack #17514

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd38bbe
add failing integration test
RobinMalfait Apr 2, 2025
2df0e59
catch errors in case `fs.rm` doesn't work
RobinMalfait Apr 2, 2025
6235e88
re-use compiler promise
RobinMalfait Apr 2, 2025
342645d
Add a working regression test
philipp-spiess Apr 3, 2025
6cd6f83
Add changelog
philipp-spiess Apr 3, 2025
10b0c76
Put compiler into a var
philipp-spiess Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Put compiler into a var
  • Loading branch information
@philipp-spiess
philipp-spiess committed Apr 3, 2025
commit 10b0c766ea657fafe191a35ed5dfc2b092356440
10 changes: 5 additions & 5 deletions packages/@tailwindcss-postcss/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,10 @@ function tailwindcss(opts: PluginOptions = {}): AcceptedPlugin {
context.compiler = createCompiler()
}

let compiler = await context.compiler

if (context.scanner === null || rebuildStrategy === 'full') {
DEBUG && I.start('Setup scanner')
let compiler = await context.compiler
let sources = (() => {
// Disable auto source detection
if (compiler.root === 'none') {
Expand All @@ -216,11 +217,10 @@ function tailwindcss(opts: PluginOptions = {}): AcceptedPlugin {
}

DEBUG && I.start('Scan for candidates')
let candidates =
(await context.compiler).features & Features.Utilities ? context.scanner.scan() : []
let candidates = compiler.features & Features.Utilities ? context.scanner.scan() : []
DEBUG && I.end('Scan for candidates')

if ((await context.compiler).features & Features.Utilities) {
if (compiler.features & Features.Utilities) {
DEBUG && I.start('Register dependency messages')
// Add all found files as direct dependencies
for (let file of context.scanner.files) {
Expand Down Expand Up @@ -269,7 +269,7 @@ function tailwindcss(opts: PluginOptions = {}): AcceptedPlugin {
}

DEBUG && I.start('Build utilities')
let tailwindCssAst = (await context.compiler).build(candidates)
let tailwindCssAst = compiler.build(candidates)
DEBUG && I.end('Build utilities')

if (context.tailwindCssAst !== tailwindCssAst) {
Expand Down